Author Topic: github version is wrong...  (Read 1144 times)

Offline johnes

  • Hero Member
  • *****
  • Posts: 629
  • Karma: +7/-7
github version is wrong...
« on: September 22, 2016, 11:38:18 am »
Missing EWextras.conf:
extrasFile = uiVar ("ExtraVariablesFile", "") -- list of extra variables to watch

Also, it took out the LoadLevelStatus stuff too.  I will try to upload a better version later - but what's in github is a step backwards....

Offline akbooer

  • Moderator
  • Master Member
  • *****
  • Posts: 6157
  • Karma: +275/-69
  • "Less is more"
Re: github version is wrong...
« Reply #1 on: September 22, 2016, 12:15:50 pm »
There should be no default file for extra variable, it's quite up to the user.  What else do you think is wrong?  The only thing, IIRC, that should have gone in the last update was the VeraLite LED status.
3x Vera Lite-UI5/Edge-UI7, 25x Fibaro, 23x TKB, 9x MiniMote, 2x NorthQ Power, 2x Netatmo, 1x Foscam FI9831P, 9x Philips Hue,
Razberry, MySensors Arduino, HomeWave, AltUI, AltHue, DataYours, Grafana, openLuup, ZWay, ZeroBrane Studio.

Offline johnes

  • Hero Member
  • *****
  • Posts: 629
  • Karma: +7/-7
Re: github version is wrong...
« Reply #2 on: September 22, 2016, 02:40:56 pm »
I have to wait to get home to look at the file again, but before, LoadLevelStatus was being tracked but now it's not.  It's a few lines of code, so no big deal - I had a backup from earlier.

As for the extras file, I agree it's up tot he user to have that file, but the code on github has:

extrasFile = uiVar ("ExtraVariablesFile", "") instead of extrasFile = uiVar ("ExtraVariablesFile", "/www/EWextras.conf")

I agree that the user should have the file if they want, but they shouldn't have to edit the Lua file to make that happen should they?

Offline akbooer

  • Moderator
  • Master Member
  • *****
  • Posts: 6157
  • Karma: +275/-69
  • "Less is more"
Re: github version is wrong...
« Reply #3 on: September 22, 2016, 03:32:39 pm »
I have to wait to get home to look at the file again, but before, LoadLevelStatus was being tracked but now it's not.  It's a few lines of code, so no big deal - I had a backup from earlier.

As for the extras file, I agree it's up tot he user to have that file, but the code on github has:

extrasFile = uiVar ("ExtraVariablesFile", "") instead of extrasFile = uiVar ("ExtraVariablesFile", "/www/EWextras.conf")

I agree that the user should have the file if they want, but they shouldn't have to edit the Lua file to make that happen should they?

If there's something wrong then we should fix it for all users, not just for you.  I appreciate the heads up, but you should appreciate that this software is free, you use it at your own risk, and you stand a better chance of getting fixed by politely pointing it out any problems, rather than baldly stating something is worse than it was before.
3x Vera Lite-UI5/Edge-UI7, 25x Fibaro, 23x TKB, 9x MiniMote, 2x NorthQ Power, 2x Netatmo, 1x Foscam FI9831P, 9x Philips Hue,
Razberry, MySensors Arduino, HomeWave, AltUI, AltHue, DataYours, Grafana, openLuup, ZWay, ZeroBrane Studio.