We have moved at community.getvera.com

Author Topic: Testing Branch: 2018 Release 5.15  (Read 460 times)

Offline rafale77

  • Community Beta
  • Hero Member
  • ******
  • Posts: 1749
  • Karma: +101/-27
  • HA ≠ IoT as a blue sky is cloudless.
Testing Branch: 2018 Release 5.15
« on: May 24, 2018, 08:57:43 pm »
I have started testing this branch by merging it into my dev fork which now has a couple of more changes (http-digest, initiation of attributes and altui pluginconfig variable) and so far has been working without any hickup.
openLuup (79 devices, 141 scenes, 19 apps) master to VeraPlus (142 zwave nodes, 8 Zigbee nodes, 221 devices,  20 scenes , 2 apps) +  Hubitat (15 Zigbee nodes) + Home-Assistant (API Integrations). Bridged to Siri and Alexa. Homewave. VeraPlus ExtRooted and mios server independent.

Offline rafale77

  • Community Beta
  • Hero Member
  • ******
  • Posts: 1749
  • Karma: +101/-27
  • HA ≠ IoT as a blue sky is cloudless.
Re: Testing Branch: 2018 Release 5.15
« Reply #1 on: May 25, 2018, 12:12:33 am »
Found the first problem. It seems like the new XML module is not working with the Sonos plugin.

Confirmed. The new XML parser is failing to parse the implementation XML of the sonos plugin. I reverted the loader.lua and it is working again.
« Last Edit: May 25, 2018, 03:37:51 am by rafale77 »
openLuup (79 devices, 141 scenes, 19 apps) master to VeraPlus (142 zwave nodes, 8 Zigbee nodes, 221 devices,  20 scenes , 2 apps) +  Hubitat (15 Zigbee nodes) + Home-Assistant (API Integrations). Bridged to Siri and Alexa. Homewave. VeraPlus ExtRooted and mios server independent.

Offline rafale77

  • Community Beta
  • Hero Member
  • ******
  • Posts: 1749
  • Karma: +101/-27
  • HA ≠ IoT as a blue sky is cloudless.
Re: Testing Branch: 2018 Release 5.15
« Reply #2 on: May 25, 2018, 02:44:04 pm »
Found another problem which was probably there before:
When user an interval in the scene timer, the next run does not report appropriately. It looks like it is picking os.time() as the next_run and does not appear to calculate the next due date.
openLuup (79 devices, 141 scenes, 19 apps) master to VeraPlus (142 zwave nodes, 8 Zigbee nodes, 221 devices,  20 scenes , 2 apps) +  Hubitat (15 Zigbee nodes) + Home-Assistant (API Integrations). Bridged to Siri and Alexa. Homewave. VeraPlus ExtRooted and mios server independent.

Offline rafale77

  • Community Beta
  • Hero Member
  • ******
  • Posts: 1749
  • Karma: +101/-27
  • HA ≠ IoT as a blue sky is cloudless.
Re: Testing Branch: 2018 Release 5.15
« Reply #3 on: May 25, 2018, 08:12:06 pm »
I managed to fix the interval timer problem... It is in my fork and pushed to AK whenever he gets back.
openLuup (79 devices, 141 scenes, 19 apps) master to VeraPlus (142 zwave nodes, 8 Zigbee nodes, 221 devices,  20 scenes , 2 apps) +  Hubitat (15 Zigbee nodes) + Home-Assistant (API Integrations). Bridged to Siri and Alexa. Homewave. VeraPlus ExtRooted and mios server independent.

Offline akbooer

  • Moderator
  • Master Member
  • *****
  • Posts: 6387
  • Karma: +292/-70
  • "Less is more"
Re: Testing Branch: 2018 Release 5.15
« Reply #4 on: May 29, 2018, 05:42:26 am »
The new XML parser is failing to parse the implementation XML of the sonos plugin. I reverted the loader.lua and it is working again.

It's true that the Sonos plugin failed to load, but the problem is not with the XML parser, which is working perfectly well.

Bizarrely, the problem is caused by a Lua comment line at the end of some of the (many) actions defined in the Sonos implementation file.  This plugin is the only one I've ever seen which does this, and whilst I had forseen and dealt with that condition in the main body of the functions tag, I had omitted to do so in for the individual actions.

A one-character change in the loader module fixes this, and the testing branch has been updated.
3x Vera Lite-UI5/Edge-UI7, 25x Fibaro, 23x TKB, 9x MiniMote, 2x NorthQ Power, 2x Netatmo, 1x Foscam FI9831P, 9x Philips Hue,
Razberry, MySensors Arduino, HomeWave, AltUI, AltHue, DataYours, Grafana, openLuup, ZWay, ZeroBrane Studio.

Offline rafale77

  • Community Beta
  • Hero Member
  • ******
  • Posts: 1749
  • Karma: +101/-27
  • HA ≠ IoT as a blue sky is cloudless.
Re: Testing Branch: 2018 Release 5.15
« Reply #5 on: May 29, 2018, 11:23:08 am »
Thank you for fixing this! It's a pretty amazing find too. I will test later today.
openLuup (79 devices, 141 scenes, 19 apps) master to VeraPlus (142 zwave nodes, 8 Zigbee nodes, 221 devices,  20 scenes , 2 apps) +  Hubitat (15 Zigbee nodes) + Home-Assistant (API Integrations). Bridged to Siri and Alexa. Homewave. VeraPlus ExtRooted and mios server independent.

Offline akbooer

  • Moderator
  • Master Member
  • *****
  • Posts: 6387
  • Karma: +292/-70
  • "Less is more"
Re: Testing Branch: 2018 Release 5.15
« Reply #6 on: May 29, 2018, 11:38:29 am »
I managed to fix the interval timer problem... It is in my fork and pushed to AK whenever he gets back.

Take a look at the GitHub comment on the pull request - I don't believe that this fix is correct.
3x Vera Lite-UI5/Edge-UI7, 25x Fibaro, 23x TKB, 9x MiniMote, 2x NorthQ Power, 2x Netatmo, 1x Foscam FI9831P, 9x Philips Hue,
Razberry, MySensors Arduino, HomeWave, AltUI, AltHue, DataYours, Grafana, openLuup, ZWay, ZeroBrane Studio.

Offline rafale77

  • Community Beta
  • Hero Member
  • ******
  • Posts: 1749
  • Karma: +101/-27
  • HA ≠ IoT as a blue sky is cloudless.
Re: Testing Branch: 2018 Release 5.15
« Reply #7 on: May 29, 2018, 01:23:34 pm »
Your assessment is correct. I made one change too many. I will revert it. Also I verified that the SONOS plugin is working fine with your updates.
openLuup (79 devices, 141 scenes, 19 apps) master to VeraPlus (142 zwave nodes, 8 Zigbee nodes, 221 devices,  20 scenes , 2 apps) +  Hubitat (15 Zigbee nodes) + Home-Assistant (API Integrations). Bridged to Siri and Alexa. Homewave. VeraPlus ExtRooted and mios server independent.

Offline akbooer

  • Moderator
  • Master Member
  • *****
  • Posts: 6387
  • Karma: +292/-70
  • "Less is more"
Re: Testing Branch: 2018 Release 5.15
« Reply #8 on: May 29, 2018, 01:30:08 pm »
Your assessment is correct. I made one change too many. I will revert it. Also I verified that the SONOS plugin is working fine with your updates.

OK, glad to know that Sonos is behaving.

Don't bother to change that on GitHub... it's bit a bit hard to wade through all the commits you made.  I think in future that one pull request per issue would be much easier.  Anyway, the current testing code has diverged so much from the original that we need to start again.

Next step is the digest authentication.
3x Vera Lite-UI5/Edge-UI7, 25x Fibaro, 23x TKB, 9x MiniMote, 2x NorthQ Power, 2x Netatmo, 1x Foscam FI9831P, 9x Philips Hue,
Razberry, MySensors Arduino, HomeWave, AltUI, AltHue, DataYours, Grafana, openLuup, ZWay, ZeroBrane Studio.